[v10] refactor: use ImplicitDiscreteSystem to implement affects in callback systems
#3452
+1,508
−1,576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyudu
force-pushed
the
callback
branch
2 times, most recently
from
4a6f2f6 to
b7997b0
Compare
isaacsas
reviewed
Mar 21, 2025
isaacsas
reviewed
Mar 26, 2025
vyudu
changed the title
ImplicitDiscreteSystem to implement affects in callback systems ImplicitDiscreteSystem to implement affects in callback systems
|
@ChrisRackauckas @AayushSabharwal This is very close, just needs a release for ImplicitDiscreteSolve and getting all the doc blocks working. One of the FMI tests is failing because the reinitialization isn't accurate enough (like 1.008e-8 but the tolerance is 1e-8), but I am unsure if that is related. |
vyudu
changed the title
ImplicitDiscreteSystem to implement affects in callback systems ImplicitDiscreteSystem to implement affects in callback systems
| @@ -25,6 +25,67 @@ the event occurs). These can both be specified symbolically, but a more [general | |||
| functional affect](@ref func_affects) representation is also allowed, as described | |||
| below. | |||
|
|
|||
| ## Symbolic Callback Semantics (changed in V10) | |||
There was a problem hiding this comment.
Suggested change
| ## Symbolic Callback Semantics (changed in V10) | |
| ## Symbolic Callback Semantics |
Mention that in the NEWS.md file.
| @@ -54,6 +54,7 @@ import Moshi | |||
| using Moshi.Data: @data | |||
| using NonlinearSolve | |||
| import SCCNonlinearSolve | |||
| using ImplicitDiscreteSolve | |||
There was a problem hiding this comment.
why is this needed as a hard dep?
There was a problem hiding this comment.
IDSolve is called in the implicit affect codegen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2639 #2612